Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library jamfile is non-conforming #2649

Closed
vinniefalco opened this issue Mar 4, 2023 · 4 comments
Closed

library jamfile is non-conforming #2649

vinniefalco opened this issue Mar 4, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@vinniefalco
Copy link
Member

The Jamfile for the compiled lib should be in build/Jamfile not the root Jamfile, which probably should be stripped down and/or removed. The library name is "lib-beast" which is also not normal it should be "boost_beast".

@vinniefalco
Copy link
Member Author

Also the file test/lib_beast.cpp should be in src/lib_beast.cpp

@klemens-morgenstern klemens-morgenstern added this to the 1.83 milestone Mar 6, 2023
@klemens-morgenstern
Copy link
Collaborator

klemens-morgenstern commented May 17, 2023

I think that's a bad idea without having openssl.jam work properly. And I can't get this work.

The reason is that we need a boost wide ssl target, so that dependent libraries, like requests can pick this up.

@vinniefalco
Copy link
Member Author

Ah yes I knew I had a reason. And I tried to get the openssl to work, but I failed. You will probably succeed though.

@klemens-morgenstern
Copy link
Collaborator

I made openssl.jam work. But I will still keep lib_beast and lib_asio where they are (in root). Not exported and used by example & test. Exporting a beast target is a bad idea until we have something similar for asio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants