Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for leading space #142

Closed
Flamefire opened this issue Jan 26, 2024 · 0 comments · Fixed by #144
Closed

Add tests for leading space #142

Flamefire opened this issue Jan 26, 2024 · 0 comments · Fixed by #144

Comments

@Flamefire
Copy link
Contributor

A difference of std::from_chars to std::strto* (for both integer and float parsers) is

leading whitespace is not ignored.

I don't see that in the "invalid input" tests. I guess it makes sense to test that too.

And the documentation should cover what the input strings are expected to be. I've found the various format descriptions for floats in an extra section, but none for int. It only states stuff in terms of "matching the pattern", but for ints I wasn't able to find which pattern is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant