Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddressSanitizer support #12

Closed
vinniefalco opened this issue Aug 4, 2017 · 6 comments
Closed

AddressSanitizer support #12

vinniefalco opened this issue Aug 4, 2017 · 6 comments

Comments

@vinniefalco
Copy link
Member

Can we please add something like <asan>on (similar to <valgrind>on) which informs AddressSanitizer of the stack changes? It is described here:
google/sanitizers#189 (comment)
https://github.com/llvm-mirror/compiler-rt/blob/master/include/sanitizer/common_interface_defs.h#L166

@vinniefalco
Copy link
Member Author

Does BOOST_USE_ASAN work?

@olk
Copy link
Member

olk commented Aug 4, 2017

I think yes, but you need a very up-to-date version of libasan.
It is only applicable to ucontext (don't know if ASAN is supported on windows - especially the __sanitizer_start_switch_fiber etc.). You can not use it for the assembler backend because this code has no access to the fake-stack, stack-bottom etc. - no global pointer as in ucontext backend.

@olk olk closed this as completed Aug 4, 2017
@vinniefalco
Copy link
Member Author

That's cool, I just want to get rid of the false positives. I only run ubsan and asan as part of the CI tests on Travis and they make heavy use of Asio coroutines:
https://travis-ci.org/vinniefalco/beast/jobs/260836700#L1417

So I think this will work well, thanks!

@bog-dan-ro
Copy link

Do you have more info on this matter? E.g. what is the minimum boost, asan & gcc versions?
I tried Debian's testing boost 1.67 and gcc 8 and the false positive is still there...

@olk
Copy link
Member

olk commented Oct 24, 2018

I'm sorry, no - no new infos

@hamparawa
Copy link
Contributor

I've also experienced issues with GCC as well. Therefore I had to switched to Clang latest only for CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants