Clang and ICC on Windows fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It requires `vswhere` to discover VC paths.
|
I do not see Appveyor here, it seems to be not enabled for the repository? Here are results from the PR source slag https://ci.appveyor.com/project/Kojoley/dll/builds/29038837 |
|
Many many thanks for the fixes! |
That's strange. I have that line in all the CI and it works pretty well https://github.com/boostorg/variant/blob/c401edba70c9f3668dae55ee1cfa5d9b2c6fc2fc/.travis.yml#L21 |
|
Probably the repositories have define |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still have an issue on Clang, because ctti on it returns a space after a comma that delimits template arguments while demangler does not (
boost::variant<double, int>vsboost::variant<double,int>).Also had to fix CI issues. Some of them are not mandatory, but
embed-manifest=offpart required to Clang on VS2019 image (for some reason Boost.Build does not findmt.exe),dist: trustyrequired because Travis switched default image toxenial.