Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows.h illegally uses #define small char, explore possible work-arounds #342

Closed
HDembinski opened this issue Sep 30, 2021 · 0 comments · Fixed by #343
Closed

windows.h illegally uses #define small char, explore possible work-arounds #342

HDembinski opened this issue Sep 30, 2021 · 0 comments · Fixed by #343

Comments

@HDembinski
Copy link
Collaborator

According to my research, it is not possible to work around this error in the windows.h header in this library without breaking the API.

https://stackoverflow.com/questions/21165891/is-small-a-keyword-in-c

We could deprecate the old API for everyone and add new methods large_part and small_part as suggested in #341. When the preprocessor detects that small is set, it would not compile the deprecated API. This should fix the issue for those that are affected but not break the code of other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant