Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.76 now requires unicode paths on windows #145

Closed
rconde01 opened this issue Jun 8, 2021 · 2 comments
Closed

1.76 now requires unicode paths on windows #145

rconde01 opened this issue Jun 8, 2021 · 2 comments

Comments

@rconde01
Copy link

rconde01 commented Jun 8, 2021

If you use BOOST_INTERPROCESS_SHARED_DIR_PATH with std::string, you now get a compile error on windows because BOOST_INTERPROCESS_WCHAR_NAMED_RESOURCES is unconditionally true.

@rconde01
Copy link
Author

rconde01 commented Jun 8, 2021

just realized its broken because no matter what you pick, there's a wchar_t and char overload of shared_memory_object::remove

@igaztanaga
Copy link
Member

I didn't notice the breakage, because there was no associated test in the testsuite. I've modified the documentation to notice that BOOST_INTERPROCESS_SHARED_DIR_WPATH should be added in Windows and modified the implementation to be able to compile without BOOST_INTERPROCESS_SHARED_DIR_WPATH (it will use standard shared memory path for wide functions).

Also added a test for the feature so that some bugs can be detected in the future when changing internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants