New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UB due to union based type punning #46

Closed

Flamefire opened this issue Aug 23, 2019 · 1 comment

Flamefire commented Aug 23, 2019

intrusive/include/boost/intrusive/detail/math.hpp

Line 215 in 3b5001f

} caster;

uses an union to convert a float to an int. This has 2 problems each causing UB:

a float may not be a IEEE754 float (I think this can be checked via defines)
Accessing an inactive union member is UB (this can be fixed by a memcpy which is optimized away by the compiler)

Member

igaztanaga commented Jan 16, 2020

The implementation does not support anything that is not IEEE754, which is extremly rare there days, so this won't be fixed.
As you suggest, a memcpy is the correct fix.

igaztanaga closed this as completed in

d876178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment