Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC suggest-override warnings #111

Open
EugeneZelenko opened this issue Apr 4, 2020 · 1 comment
Open

GCC suggest-override warnings #111

EugeneZelenko opened this issue Apr 4, 2020 · 1 comment

Comments

@EugeneZelenko
Copy link

EugeneZelenko commented Apr 4, 2020

GCC 7.5 fires suggest-override warnings in Boost 1.72:

include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:211:6: error: ‘bool boost::iostreams::detail::indirect_streambuf::auto_close() const [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:215:6: error: ‘void boost::iostreams::detail::indirect_streambuf::set_auto_close(bool) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:319:6: error: ‘bool boost::iostreams::detail::indirect_streambuf::strict_sync() [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:222:6: error: ‘void boost::iostreams::detail::indirect_streambuf::imbue(const std::locale&) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:234:1: error: ‘boost::iostreams::detail::indirect_streambuf::int_type boost::iostreams::detail::indirect_streambuf::underflow() [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:269:1: error: ‘boost::iostreams::detail::indirect_streambuf::int_type boost::iostreams::detail::indirect_streambuf::pbackfail(boost::iostreams::detail::indirect_streambuf::int_type) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:283:1: error: ‘boost::iostreams::detail::indirect_streambuf::int_type boost::iostreams::detail::indirect_streambuf::overflow(boost::iostreams::detail::indirect_streambuf::int_type) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:309:5: error: ‘int boost::iostreams::detail::indirect_streambuf::sync() [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:329:1: error: ‘boost::iostreams::detail::indirect_streambuf::pos_type boost::iostreams::detail::indirect_streambuf::seekoff(boost::iostreams::detail::indirect_streambuf::off_type, std::ios_base::seekdir, std::ios_base::openmode) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::pos_type = std::fpos<__mbstate_t>; boost::iostreams::detail::indirect_streambuf::off_type = long int; std::ios_base::seekdir = std::_Ios_Seekdir; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:335:1: error: ‘boost::iostreams::detail::indirect_streambuf::pos_type boost::iostreams::detail::indirect_streambuf::seekpos(boost::iostreams::detail::indirect_streambuf::pos_type, std::ios_base::openmode) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::pos_type = std::fpos<__mbstate_t>; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:378:13: error: ‘void boost::iostreams::detail::indirect_streambuf::set_next(boost::iostreams::detail::indirect_streambuf::streambuf_type*) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::iostreams::detail::indirect_streambuf::streambuf_type = boost::iostreams::detail::linked_streambuf >; typename boost::iostreams::char_type_of::type = char]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:383:13: error: ‘void boost::iostreams::detail::indirect_streambuf::close_impl(std::ios_base::openmode) [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:97:34: error: ‘const typeinfo& boost::iostreams::detail::indirect_streambuf::component_type() const [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output; boost::core::typeinfo = std::type_info]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:98:11: error: ‘void* boost::iostreams::detail::indirect_streambuf::component_impl() [with T = boost::iostreams::back_insert_device >; Tr = std::char_traits; Alloc = std::allocator; Mode = boost::iostreams::output]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:63:10: error: ‘bool boost::iostreams::detail::direct_streambuf::auto_close() const [with T = boost::iostreams::basic_array_source; Tr = std::char_traits]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:64:10: error: ‘void boost::iostreams::detail::direct_streambuf::set_auto_close(bool) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:65:10: error: ‘bool boost::iostreams::detail::direct_streambuf::strict_sync() [with T = boost::iostreams::basic_array_source; Tr = std::char_traits]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:202:6: error: ‘void boost::iostreams::detail::direct_streambuf::close_impl(std::ios_base::openmode) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:77:34: error: ‘const typeinfo& boost::iostreams::detail::direct_streambuf::component_type() const [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::core::typeinfo = std::type_info]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:78:11: error: ‘void* boost::iostreams::detail::direct_streambuf::component_impl() [with T = boost::iostreams::basic_array_source; Tr = std::char_traits]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:140:1: error: ‘boost::iostreams::detail::direct_streambuf::int_type boost::iostreams::detail::direct_streambuf::underflow() [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::iostreams::detail::direct_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:153:1: error: ‘boost::iostreams::detail::direct_streambuf::int_type boost::iostreams::detail::direct_streambuf::pbackfail(boost::iostreams::detail::direct_streambuf::int_type) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::iostreams::detail::direct_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:169:1: error: ‘boost::iostreams::detail::direct_streambuf::int_type boost::iostreams::detail::direct_streambuf::overflow(boost::iostreams::detail::direct_streambuf::int_type) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::iostreams::detail::direct_streambuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:189:1: error: ‘boost::iostreams::detail::direct_streambuf::pos_type boost::iostreams::detail::direct_streambuf::seekoff(boost::iostreams::detail::direct_streambuf::off_type, std::ios_base::seekdir, std::ios_base::openmode) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::iostreams::detail::direct_streambuf::pos_type = std::fpos<__mbstate_t>; boost::iostreams::detail::direct_streambuf::off_type = long int; std::ios_base::seekdir = std::_Ios_Seekdir; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/direct_streambuf.hpp:195:1: error: ‘boost::iostreams::detail::direct_streambuf::pos_type boost::iostreams::detail::direct_streambuf::seekpos(boost::iostreams::detail::direct_streambuf::pos_type, std::ios_base::openmode) [with T = boost::iostreams::basic_array_source; Tr = std::char_traits; boost::iostreams::detail::direct_streambuf::pos_type = std::fpos<__mbstate_t>; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/filtering_stream.hpp:98:10: error: ‘void boost::iostreams::detail::filtering_stream_base::notify() [with Chain = boost::iostreams::chain, std::allocator >; Access = boost::iostreams::public_]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:54:14: error: ‘boost::iostreams::detail::chainbuf::int_type boost::iostreams::detail::chainbuf::underflow() [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; boost::iostreams::detail::chainbuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:56:14: error: ‘boost::iostreams::detail::chainbuf::int_type boost::iostreams::detail::chainbuf::pbackfail(boost::iostreams::detail::chainbuf::int_type) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; boost::iostreams::detail::chainbuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:58:21: error: ‘std::streamsize boost::iostreams::detail::chainbuf::xsgetn(boost::iostreams::detail::chainbuf::char_type*, std::streamsize) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; std::streamsize = long int; boost::iostreams::detail::chainbuf::char_type = char]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:60:14: error: ‘boost::iostreams::detail::chainbuf::int_type boost::iostreams::detail::chainbuf::overflow(boost::iostreams::detail::chainbuf::int_type) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; boost::iostreams::detail::chainbuf::int_type = int]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:62:21: error: ‘std::streamsize boost::iostreams::detail::chainbuf::xsputn(const char_type*, std::streamsize) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; std::streamsize = long int; boost::iostreams::detail::chainbuf::char_type = char]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:64:9: error: ‘int boost::iostreams::detail::chainbuf::sync() [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:65:14: error: ‘boost::iostreams::detail::chainbuf::pos_type boost::iostreams::detail::chainbuf::seekoff(boost::iostreams::detail::chainbuf::off_type, std::ios_base::seekdir, std::ios_base::openmode) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; boost::iostreams::detail::chainbuf::pos_type = std::fpos<__mbstate_t>; boost::iostreams::detail::chainbuf::off_type = long int; std::ios_base::seekdir = std::_Ios_Seekdir; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
include/boost/iostreams/detail/streambuf/chainbuf.hpp:69:14: error: ‘boost::iostreams::detail::chainbuf::pos_type boost::iostreams::detail::chainbuf::seekpos(boost::iostreams::detail::chainbuf::pos_type, std::ios_base::openmode) [with Chain = boost::iostreams::chain, std::allocator >; Mode = boost::iostreams::input; Access = boost::iostreams::public_; boost::iostreams::detail::chainbuf::pos_type = std::fpos<__mbstate_t>; std::ios_base::openmode = std::_Ios_Openmode]’ can be marked override [-Werror=suggest-override]
@mclow
Copy link
Contributor

mclow commented Apr 7, 2020

Related: boostorg/config#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants