Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus MSVC14.0 C4702 warning #80

Open
Kojoley opened this issue Feb 28, 2019 · 4 comments
Open

Bogus MSVC14.0 C4702 warning #80

Kojoley opened this issue Feb 28, 2019 · 4 comments

Comments

@Kojoley
Copy link
Contributor

Kojoley commented Feb 28, 2019

I do not see them from MSVC14.1.

boost\iostreams\detail\streambuf\indirect_streambuf.hpp(257) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(258) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(259) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(261) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(262) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(257) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(258) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(259) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(261) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(262) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(433) : warning C4702: unreachable code
boost\iostreams\detail\streambuf\indirect_streambuf.hpp(433) : warning C4702: unreachable code
@mclow
Copy link
Contributor

mclow commented Mar 1, 2019

Can I have more information (boost version, etc)?
Because here's the code I see:

screen shot 2019-02-28 at 5 12 39 pm

@Kojoley
Copy link
Contributor Author

Kojoley commented Mar 1, 2019

boost version

develop branch

etc

I do not know what other information I can provide. It is exactly on those lines, it has to be a compiler bug because 14.1 does not produce those warnings, but I am not sure so posted as issue. If it ok I can open a PR with suppressing them otherwise I will just suppress the warning from the whole include on my side.

@jeking3
Copy link
Contributor

jeking3 commented Mar 1, 2019

Look at the AppVeyor CI builds where MSVC 14.0 (2015) is tested:
https://ci.appveyor.com/project/eldiener/iostreams/builds/22626745
I only see:

c:\projects\boost-root\boost\test\impl\execution_monitor.ipp(1296) : warning C4702: unreachable code

Look at the regression test matrix for iostreams, for MSVC 14.0:
https://www.boost.org/development/tests/develop/developer/iostreams.html
I do not see it there (but I see what looks like 4 possibly bogus failure detections for MSVC 14.0.

It does not show up in our test environments. Please post a test and/or the git commit where you saw the issue so we can be looking at the correct code.

@Kojoley
Copy link
Contributor Author

Kojoley commented Mar 1, 2019

b2 variant=release address-model=64 cxxflags=/w14702 warnings-as-errors=on toolset=msvc-14.0 libs/spirit/classic/test//tree_to_xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants