Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caller provided serializer storage #848

Merged
merged 1 commit into from Jan 28, 2023

Conversation

grisumbras
Copy link
Member

Fix #844

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #848 (c06b17a) into develop (d7b7bef) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #848      +/-   ##
===========================================
+ Coverage    99.00%   99.19%   +0.19%     
===========================================
  Files           70       70              
  Lines         6837     6849      +12     
===========================================
+ Hits          6769     6794      +25     
+ Misses          68       55      -13     
Impacted Files Coverage Δ
include/boost/json/serializer.hpp 100.00% <ø> (ø)
include/boost/json/detail/impl/stack.ipp 100.00% <100.00%> (ø)
include/boost/json/detail/stack.hpp 100.00% <100.00%> (ø)
include/boost/json/impl/serialize.ipp 94.93% <100.00%> (+7.59%) ⬆️
include/boost/json/impl/serializer.ipp 98.62% <100.00%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b7bef...c06b17a. Read the comment docs.

@cppalliance-bot
Copy link

@grisumbras grisumbras merged commit c06b17a into boostorg:develop Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost::json::serializer should take a storage_ptr
3 participants