Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++17 fixes not merged to master #23

Closed
pdimov opened this issue Nov 20, 2017 · 3 comments
Closed

C++17 fixes not merged to master #23

pdimov opened this issue Nov 20, 2017 · 3 comments

Comments

@pdimov
Copy link
Member

pdimov commented Nov 20, 2017

The commit

322437a

that enables compilation on C++17 has not been applied to master. It's too late for the 1.66 beta, but perhaps it needs to be applied for the 1.66 release once master is open for changes?
@artyom-beilis
Copy link
Member

Ok good point

@pdimov pdimov changed the title C++17 fixes not merged to develop C++17 fixes not merged to master Nov 21, 2017
@pdimov
Copy link
Member Author

pdimov commented Jan 15, 2018

master still doesn't build on C++17.

@artyom-beilis
Copy link
Member

Merged all changes in develop to master.

Now should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdimov @artyom-beilis