Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log does not respect BOOST_LOG_BUILD_DLL #42

Closed
egorpugin opened this issue Sep 24, 2017 · 1 comment
Closed

Log does not respect BOOST_LOG_BUILD_DLL #42

egorpugin opened this issue Sep 24, 2017 · 1 comment

Comments

@egorpugin
Copy link

egorpugin commented Sep 24, 2017

Hi,

While all (almost all?) boost libs respect definition BOOST_ + libname + _BUILD_DLL when building shared library itself, boost.log uses it own BOOST_LOG_DLL definition to say we're compiling a shared library.
See https://github.com/boostorg/log/blob/develop/include/boost/log/detail/config.hpp#L252 and other occurences of BOOST_LOG_DLL.

For reference see boost.thread https://github.com/boostorg/thread/blob/develop/include/boost/thread/detail/config.hpp#L402

Is it possible to fix this to use common boost behavior?
It will be useful in custom (not b2) boost builds like in my case.

@Lastique
Copy link
Member

Sorry, I don't want to do this. There is no common mechanism to indicate that a library is being built as a shared library, every library has its own macro for that. That macro isn't public, it is intended to be used by the build scripts provided by the library. If you want to write your own scripts you will have to adapt it to each library's internals individually (or patch the code). Note however that library internals may change at any time without preserving backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants