Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float128 with gcc master #992

Closed
sloriot opened this issue Jun 6, 2023 · 6 comments · Fixed by #993
Closed

float128 with gcc master #992

sloriot opened this issue Jun 6, 2023 · 6 comments · Fixed by #993

Comments

@sloriot
Copy link

sloriot commented Jun 6, 2023

Hi,

with gcc@ce2188e4320cbb46d6246bd3f478ba20440c62f3, I have the following error during compilation:

boost_1_82_0/include/boost/math/cstdfloat/cstdfloat_limits.hpp:46:13: error: redefinition of ‘class std::numeric_limits<__float128>’
   46 |       class numeric_limits<boost::math::cstdfloat::detail::float_internal128_t>

I guess it has to do with BOOST_CSTDFLOAT_HAS_INTERNAL_FLOAT128_T being not correctly defined after gcc's update or something like that. I only tested boost 1.82 (sorry if it has already been fixed in HEAD).

cc @afabri

@sloriot
Copy link
Author

sloriot commented Jun 6, 2023

minimal example:

#include <boost/math/cstdfloat/cstdfloat_limits.hpp>

int main()
{}

@mborland
Copy link
Member

mborland commented Jun 6, 2023

minimal example:

#include <boost/math/cstdfloat/cstdfloat_limits.hpp>

int main()
{}

I don't see it with GCC 13.1 on godbolt: https://godbolt.org/z/h39GTMz16.

@sloriot
Copy link
Author

sloriot commented Jun 6, 2023

that's gcc master targeting gcc 14

@mborland
Copy link
Member

mborland commented Jun 6, 2023

that's gcc master targeting gcc 14

That's fun. Thanks for the heads up.

@afabri
Copy link

afabri commented Jun 7, 2023

x86-64 gcc (trunk) in godbolt, right?

@mborland
Copy link
Member

mborland commented Jun 7, 2023

x86-64 gcc (trunk) in godbolt, right?

Yes, and it does reproduce the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants