CMake configuration file missing dependency to MPI::MPI_C

[sdebionne]

The CMake configuration files generated at installation with boostorg/boost_install have an imported target that is missing a dependency to the underlying MPI library. The symptoms are an invalid linking order and the associated undefined symbols errors.

@pdimov, what would be the right way to have something like find_dependency(MPI) and target_link_libraries(Boost::mpi PUBLIC MPI::MPI_C) added to the config file? Shall we add a test for MPI to the boost_install test suite?

[pdimov]

Yes, adding a test will certainly be a required part of the solution.

[aminiussi]

As for now, there still might be a problem with open MPI:

When including mpi.h, most the OpenMPI distribution I've found so far insist on detecting a C++ compiler, thus including the legacy C++ headers, which in turn brings in some (unused) C++ MPI symbols.

And I think OpenMPI is the most widespread MPI implementation.

I'm planing to explicitly prohibit that by default (#73) but untill then... (I'll try to do it this we at least on develop).

I have no experience with boostorg/boost_install yet.

[pdimov]

I'll transfer this issue to boost_install.

[pdimov]

As far as I can see, what's needed is 63c74f6.

It's not possible to use PUBLIC for an imported library, only INTERFACE linking is allowed, but I hope CMake does the right thing with those.

I don't have a way to test that at present; it's on the feature/add-mpi-dependency branch. I'll merge it to develop upon confirmation that it works.

[sdebionne]

I had a look at Boost.Iostreams that also have dependencies to third party libraries (zlib, bzip2) and it looks like it might have the same issue. I have open an issue #18 (in parallel to your issue transfer).

It's not possible to use PUBLIC for an imported library, only INTERFACE linking is allowed, but I hope CMake does the right thing with those.

I think it does the right thing.

[pdimov]

Looking at the documentation of FindMPI,

• shouldn't the correct target be MPI::MPI_CXX?
• seems that targets are only available in CMake 3.10, not sure whether we need to care about that though.

[pdimov]

Yes, find_dependency(MPI) finds just MPI_CXX for me by default, and does not declare MPI::MPI_C.

[pdimov]

Almost done; the MPI tests just fail because of boostorg/mpi@8619d7b#commitcomment-35672247.

[pdimov]

Merged to develop.

[sdebionne]

@pdimov Thank you very much! I'll try to find some time to contribute a test.

[pdimov]

It already has a test: https://github.com/boostorg/boost_install/tree/develop/test/mpi