Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of non BOOST-prefixed macros #185

Closed
ned14 opened this issue Dec 16, 2019 · 1 comment
Closed

List of non BOOST-prefixed macros #185

ned14 opened this issue Dec 16, 2019 · 1 comment

Comments

@ned14
Copy link
Member

ned14 commented Dec 16, 2019

The following macros are missing a BOOST_ prefix, which is against Boost library guidelines:

./boost/archive/detail/basic_oarchive.hpp:        vsave(NULL_POINTER_TAG);
./boost/archive/basic_archive.hpp:#define NULL_POINTER_TAG boost::archive::class_id_type(-1)
./boost/archive/detail/iserializer.hpp:    #define DONT_USE_HAS_NEW_OPERATOR 1
./boost/archive/detail/iserializer.hpp:    #define DONT_USE_HAS_NEW_OPERATOR 0
./boost/archive/detail/iserializer.hpp:#if ! DONT_USE_HAS_NEW_OPERATOR
./boost/archive/detail/iserializer.hpp:    #if DONT_USE_HAS_NEW_OPERATOR
@robertramey
Copy link
Member

Fixed this, ran some local tests, committed and pushed to develop. We'll leave it there until tests cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants