Add noexcept specs to x3::variant and forward_ast #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
noexcept
specifications to X3'svariant
andforward_ast
. Missing specs on the types' move constructors was showing up in my profiling and I decided to fix up the types in whole.I wasn't sure whether to use
noexcept
directly orBOOST_NOEXCEPT
/BOOST_NOEXCEPT_IF
; I couldn't find any precedent so opted for the latter.