Store id as promoted type to allow out-of-enum values #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with -fsanitize=undefined,
lexertl::token::id()
fails in lex_id_type_enum-p3:lex_regression_wide-p3 fails similarly.
token
uses 0 and boost::lexer::npos as special values, which may be outside the enum.A simple workaround is to store the promoted type and cast to
id_type
where necessary.