Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc warnings with -Wshadow compiler flag #141

Closed
nigels-com opened this issue Sep 5, 2023 · 1 comment
Closed

gcc warnings with -Wshadow compiler flag #141

nigels-com opened this issue Sep 5, 2023 · 1 comment

Comments

@nigels-com
Copy link

Looking at safe_dump_to.hpp there is a recurring pattern there of doing:

        typedef boost::stacktrace::detail::native_frame_ptr_t native_frame_ptr_t;

Which is understandable, on the face of it, improving clarity.

On the other hand, our codebase is using -Wshadow compiler flag on Linux and it is complaining about this in boost::stacktrace eventhough it's arguably a false alarm.

But looking more closely, we're already in the boost::stacktrace::detail namespace, are these additional typedefs still necessary?

@apolukhin
Copy link
Member

Many thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants