Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change background for in-line code phrases #943

Closed
Lastique opened this issue Feb 12, 2024 · 3 comments · Fixed by #1068
Closed

Don't change background for in-line code phrases #943

Lastique opened this issue Feb 12, 2024 · 3 comments · Fixed by #1068
Assignees
Labels
UI/Art Related to HTML, CSS, Tailwind, or appearance in general

Comments

@Lastique
Copy link
Member

Lastique commented Feb 12, 2024

https://www.preview.boost.org/releases/

In the text on the main website, such as the Release Notes above, the in-line code phrases are highlighted with a grey background:

Screenshot_20240213_012643

I think, this change in background is unnecessary and visually distracting, especially when there are many in-line code phrases in the text, like in Release Notes. The formatting only needs to change the font to monospace, as is the case in library docs and throughout the current Boost website.

PS: Note that this issue is only about in-line code phrases. Code blocks do need to be highlighted as blocks - either with a border around them or with a background color. Though I would probably prefer a border in this case, as it is in library docs.

@vinniefalco
Copy link
Member

Agreed

@kennethreitz kennethreitz added the UI/Art Related to HTML, CSS, Tailwind, or appearance in general label Mar 27, 2024
@julioest
Copy link
Collaborator

I'm looking into this issue

@julioest
Copy link
Collaborator

Here's the preview of the change:
remove-bg-highlight-from-code-tags-943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/Art Related to HTML, CSS, Tailwind, or appearance in general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants