Skip to content

Commit

Permalink
Fix "Stream closed" issue with pod pools (fixes #270)
Browse files Browse the repository at this point in the history
  • Loading branch information
@micha
micha committed Nov 1, 2015
1 parent 1ed1c73 commit d115b2e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion boot/pod/src/boot/pod.clj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@

(defn require-in
[pod ns]
(doto pod (.require (into-array String [(str ns)]))))
(doto pod
(with-eval-in
(require '~(symbol (str ns))))))

(defn canonical-coord
[[id & more :as coord]]
Expand Down

2 comments on commit d115b2e

@martinklepsch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micha could you explain why the with-eval-in thing works whereas plain .require doesn't?

@micha
Copy link
Contributor Author

@micha micha commented on d115b2e Nov 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinklepsch I don't know. I suspect that perhaps the pod isn't ready when .require is called on it. I'd need to get deeper into ShimDandy to really figure it out.

Please sign in to comment.