Prevent play! from throwing on systems with no audio output #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RadicalZephyr Awesome, thanks for the patch! One question, perhaps it would be better to just catch any exception there, rather than only the specific javazoom one? Seems like there really isn't any exception there that we would want to propagate up the stack any further. |
|
Yeah, that's a good question. One reason I caught the JavaZoom one specifically was that there's an explicit throw if the file isn't found. But on thinking about it today, that's probably only worthy of a I'll change it to catch |
It's possible that we could detect the presence/absence of an audio device using the Java Sound API AudioSystem, but it's not clear to me that would be more robust. This will also change problems like trying to play an supported format, or passing a non-existent file name into a printed warning instead of a hard-failure.
RadicalZephyr
force-pushed
the
520-check-for-audio-device
branch
from
510bb69
to
5b137f9
Compare
|
@micha FYI, I updated this to catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose to catch
JavaLayerExceptionbecause that constrains the types oferrors that will be caught to those originating inside of Java Layer.
It's possible that we could detect the presence/absence of an audio
device using the Java Sound API AudioSystem, but it's not clear to me
that would be more robust. This will probably also catch problems like
trying to play a format that is not supported by Java Layer.
Closes #520.