Improvements to work with Java 9 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: * update to dynapath 0.2.5 (0.2.4 was broken when AOT'd under < Java 9, but used under Java 9) * conditionally seal the AppClassLoader if it is available (it isn't under Java 9) * seal the new ParentClassLoader from boot-bin * use a URLClassLoader subclass that exposes .addURL so it can be modified (we can't call .setAccessible on URLClassLoader.addURL by default under Java 9) as the highest loader in the shim
|
I should mention that with these changes + PR4, boot works for me under Java 9-ea+148, but I haven't tried anything fancy with it, just starting a repl. |
|
I tested that this doesn't break existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
but used under Java 9)
under Java 9)
modified (we can't call .setAccessible on URLClassLoader.addURL by
default under Java 9) as the highest loader in the shim
This is part of the fix; boot-clj/boot-bin#4 is the other half. These changes shouldn't break users using a
boot.shwithout PR4.Let me know if this (or the approach in PR4) aren't appropriate, and I'm happy to discuss more here or on slack.