Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document release process in CONTRIBUTING.md #669

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

martinklepsch
Copy link
Member

@martinklepsch martinklepsch commented Dec 21, 2017

  • document what file needs to be uploaded to GitHub

@martinklepsch martinklepsch force-pushed the document-release-process branch 2 times, most recently from ceb71f0 to b19502f Compare December 21, 2017 20:09
@martinklepsch martinklepsch force-pushed the document-release-process branch 4 times, most recently from c4242e4 to 5b53af0 Compare December 23, 2017 14:14
Copy link
Contributor

@alandipert alandipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for updating. Perhaps also add link to https://github.com/boot-clj/boot-build-box

@martinklepsch
Copy link
Member Author

Oh, didn't know about this! Does it make a difference if we build with Oracle JDK or OpenJDK (assuming both v7)?

@martinklepsch
Copy link
Member Author

@alandipert I'll merge this now because I want to update in other PRs, if you want to add add a boot-build-box link + some context, go for it.

@martinklepsch martinklepsch merged commit 359cab9 into master Jan 9, 2018
@martinklepsch martinklepsch deleted the document-release-process branch January 9, 2018 17:01
@alandipert
Copy link
Contributor

alandipert commented Jan 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants