This repository has been archived by the owner on Feb 27, 2018. It is now read-only.
Support github enterprise release urls for ISO #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fmt.Printf("Latest release for %s/%s is %s\n", org, repo, tag) | ||
| url = fmt.Sprintf("https://github.com/%s/%s/releases/download/%s/boot2docker.iso", org, repo, tag) | ||
| if host == "api.github.com" { | ||
| url = fmt.Sprintf("https://github.com/%s/%s/releases/download/%s/boot2docker.iso", org, repo, tag) |
There was a problem hiding this comment.
To make this slightly simpler, couldn't this block of the if just set host = "github.com" and then move the second url = ... outside the else?
|
@SvenDowideit Any thoughts on this? Is there a chance for this to be included? Btw the travis build failure seems like an intermittent unrelated one. |
|
The Travis failure will be fixed if you rebase on master. 👍 |
|
+1 -- we will also add this to machine too. |
|
Thanks @ehazlett ❤️ LGTM @databus23 if you can rebase on master so we can have this hit Travis for a once-over compile test, I think we're ready to merge 👍 |
|
yw |
databus23
force-pushed
the
enterprise_isourl
branch
from
5f3fc03
to
bdae52f
Compare
|
Just rebased on master. We have a go from Travis... |
|
Thanks! 👍 |
tianon
added a commit
that referenced
this pull request
Feb 13, 2015
Support github enterprise release urls for ISO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
ISOURLpointing to GitHub Enterprise release API urls.So this makes the reggae to match
https://api.github.com/repos/$ORG/$REPO/releaseshttps://some.host/api/v3/$ORG/$REPO/releasesBackground: We need to maintain a fork of the boot2docker.iso on our internal github applicance to make it work inside our sealed corporate network. Having the
boot2docker downloadandboot2docker upgradework for us would be a blast.Cheers