Embed docker-compose inside boot2docker #932
Conversation
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com> Factorizing compose version to ENV for future updates Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@dduportal isn't it enough to be able to run compose inside a container? |
Hello ! In that case, target is "beginners" and "basics" users if docker who has not yet (or do not need) to think about complex filesystems path and bindings :) Also, since there is no "official" docker-compose image, i'm not fan of pushing a personnal one : it does not bring enough quality insurance on my mind. This was the philosophy of this PR, but maybe it will add more confusion also. But anyway it is just a proposal. Thank for your time ! |
Great !! |
As a total beginner that just wants to set up a dev environment in its Windows machine, I'd love to see docker-compose included by default. And even better if something like |
Updated to take in account compose 1.3.1 (https://github.com/docker/compose/releases/tag/1.3.1) |
@dduportal I like the idea, but I don't think I'm comfortable including this as-is in the base OS, and would prefer that we document the easiest way for users to do this (especially via Shouldn't users usually be running |
This will be true and make this PR irrelevant as soon as |
@tianon Yep, you're right, as @lmakarov stated, docker-compose should be run from the client outside boot2docker :) This is why I propose this PR : for now, since docker-compose for Windows is not a reality, it will help user to begin with, without suffering :) Another thing is the volume sharing which is a pain. The new Docker plugins may help, but the conceptual problem the user have still exists : I want to share the volumes from C:\bla to /app in the data container". The idea of the PR will help user to begin softly, with a docker-engine path visibility, again the time that -v will be fully supported. When the 2 things would have been implemented, i'll be the first the PR to remove the docker-compose binary :
Anyway, thank for your time :) |
Embed docker-compose inside boot2docker may be a way to solve the inequality between OS X/Linux and Windows in the brand new (and awesome) Docker Toolbox. |
Just a note here : since docker-compose is now supported in Windows, it does not make sense to pre-install inside boot2docker now :) So : closing the MR ! |
Yes ! 👍 |
@dduportal Hi, now docker-compose supports all operating system, so I think it's good time to add it to boot2docker you can check it here |
Hello @ghahramani , given:
I closed the PR because it did not make any sense, especially regarding the time investment to maintain compose version while it is already packaged on docker-toolbox. In your case, if you strongly need docker-compose inside boot2docker, you should build you own boot2docker to ensure control of this behavior. |
Hello dear maintainers !
Since we have a lot of people dealing with boot2docker + virtual box portability issues (Windows essentially, but also vbox sharing folders and filesystem homogeneity between docker and compose client with the remote system), here is a little proposal to provide compose as a full part inside boot2docker.
Cons :
Pros :
Advices ?
For reference, here is a set of related issues/discussions on that topic (sendfile + vbox, windows support, docker volume path) :
Thanks for your time !