This repository has been archived by the owner on Feb 27, 2018. It is now read-only.
Update build.sh to pull bundle dependencies #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - @tianon |
|
|
||
| cd ../Boot2Docker | ||
| curl -s -L -o virtualbox.exe http://download.virtualbox.org/virtualbox/4.3.26/VirtualBox-4.3.26-98988-Win.exe | ||
| virtualbox.exe -extract -silent -path . && rm virtualbox.exe # not neeeded after extraction |
There was a problem hiding this comment.
@SvenDowideit @tianon this guy extracts vbox msi installer for amd64 & x86. do you guys remove x86 one while bundling coz that's extra 24 MB? if so we can add another rm here.
Also bump VirtualBox version. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
LGTM ❤️ |
tianon
added a commit
that referenced
this pull request
Mar 24, 2015
Update build.sh to pull bundle dependencies
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
build.shscript to reduce manual work for wget'ing required binaries in the bundle.Also bumped the VirtualBox version.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com