Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare dependencies in the standard modules #203

Closed
andrus opened this issue Feb 7, 2018 · 4 comments
Closed

Declare dependencies in the standard modules #203

andrus opened this issue Feb 7, 2018 · 4 comments

Comments

@andrus
Copy link
Contributor

andrus commented Feb 7, 2018

Per #183 we are allowing modules to optionally declare dependencies. This is very helpful in unit tests when we are assembling partial stacks and would prefer not to use "autoLoadModules". So let's declare explicit dependencies across all standard Bootique modules.
IRus added a commit to bootique/bootique-flyway that referenced this issue Feb 7, 2018
@IRus
Add JdbcModule to dependencies in FlywayModule. bootique/bootique#203
5820771
@IRus
Copy link
Contributor

IRus commented Feb 7, 2018 •
edited

  • cayenne
  • cayenne-jcache
  • cayenne-test - not sure about this module
  • jdbc-instrumented
  • jdbc-hikaricp
  • jdbc-hikaricp-instrumented
  • jdbc-tomcat
  • jdbc-tomcat-instrumented
  • jdbc-test
  • jersey
  • jersey-jackson
  • jersey-client
  • jersey-client-instrumented
  • jetty-metrics
  • jetty-instrumented
  • job - doesn't depend on curator, since it's optional dependency
  • job-instrumented
  • jooq
  • flyway
  • linkmove
  • linkrest
  • liquibase
  • logback-sentry
  • mvc
  • mvc-mustache
  • shiro-jdbc
  • shiro-web
  • shiro-web-mdc
  • swagger
  • tapestry

IRus added a commit to bootique/bootique-job that referenced this issue Feb 7, 2018
@IRus
Declare module dependencies bootique/bootique#203
227d4a6
IRus added a commit to bootique/bootique-cayenne that referenced this issue Feb 7, 2018
@IRus
Declare module dependencies bootique/bootique#203
1f23e39
IRus added a commit to bootique/bootique-job that referenced this issue Feb 7, 2018
@IRus
Declare module dependencies bootique/bootique#203
ce548f9
IRus added a commit to bootique/bootique-jdbc that referenced this issue Feb 7, 2018
@IRus
Declare module dependencies bootique/bootique#203
82fdcb7
@IRus
Copy link
Contributor

IRus commented Feb 8, 2018

Accidentally committed changes in bootique-test to master: 97f1a3a. @andrus can you review this commit?

@andrus
Copy link
Contributor Author

andrus commented Feb 8, 2018

The test method looks fine. I am ok with it if it works :)

IRus added a commit to bootique/bootique-flyway that referenced this issue Feb 8, 2018
@IRus
Add JdbcModule to dependencies in FlywayModule. bootique/bootique#203
40fe296
IRus added a commit to bootique/bootique-logback that referenced this issue Feb 8, 2018
@IRus
Declare module dependencies bootique/bootique#203
67dfae3
IRus added a commit to bootique/bootique-job that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
40b5d22 
Dependency on bootique-curator removed, since this is optional dependency. Added tests for instrumented module.
IRus added a commit to bootique/bootique-cayenne that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
7c34ed8 
Added tests.
IRus added a commit to bootique/bootique-jdbc that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
3bb7b81 
Added tests to check that modules actually loaded.
IRus added a commit to bootique/bootique-jetty that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
4c1b859
IRus added a commit to bootique/bootique-shiro that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
d92034e
IRus added a commit to bootique/bootique-linkmove that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
62db666
IRus added a commit to bootique/bootique-agrest that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
7f3442f
IRus added a commit to bootique/bootique-jooq that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
465a368
IRus added a commit to bootique/bootique-liquibase that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
e0dfcf9
IRus added a commit to bootique/bootique-mvc that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
95c1d60
IRus added a commit to bootique/bootique-swagger that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
6e33fa2
IRus added a commit to bootique/bootique-tapestry that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
53c474a
IRus added a commit to bootique/bootique-jersey that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
b86e580
IRus added a commit to bootique/bootique-jersey-client that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
274942e
IRus added a commit to bootique/bootique-cayenne that referenced this issue Feb 9, 2018
@IRus
Declare module dependencies bootique/bootique#203
98e0998 
Added tests.
@IRus
Copy link
Contributor

IRus commented Feb 9, 2018

@andrus all modules now has dependencies

andrus added a commit to bootique/bootique-linkmove that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
feff3a4 
* updating test API
andrus added a commit to bootique/bootique-jdbc that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
6c7e676 
* new test API
andrus added a commit to bootique/bootique-jersey-client that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
e5c5b0d 
* new test API
andrus added a commit to bootique/bootique-jetty that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
6b9f796 
* new test API
andrus added a commit to bootique/bootique-job that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
fc28896 
* new test API
andrus added a commit to bootique/bootique-jooq that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
a5fed46 
* new test API
andrus added a commit to bootique/bootique-flyway that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
cb4b87b 
* new test API
andrus added a commit to bootique/bootique-agrest that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
880f4d9 
* new test API
andrus added a commit to bootique/bootique-liquibase that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
430f5da 
* new test API
andrus added a commit to bootique/bootique-logback that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
831bb07 
* new test API
andrus added a commit to bootique/bootique-mvc that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
200c8e7 
* new test API
andrus added a commit to bootique/bootique-shiro that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
a9b3112 
* new test API
andrus added a commit to bootique/bootique-swagger that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
1d0d757 
* new test API
andrus added a commit to bootique/bootique-tapestry that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
1ed156f 
* new test API
andrus added a commit to bootique/bootique-jersey that referenced this issue Feb 18, 2018
@andrus
Declare module dependencies bootique/bootique#203
5237418 
* new test API
@andrus andrus closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrus @IRus