Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save file in utf-8 explicitly for Windows compat #43

Merged
merged 1 commit into from
May 12, 2020
Merged

Save file in utf-8 explicitly for Windows compat #43

merged 1 commit into from
May 12, 2020

Conversation

boltomli
Copy link
Contributor

When dealing with Chinese characters on Chinese version Windows, the file is saved in CP936 that will make the output not usable (shown and read as umlaut, etc.). Save the temp file for espeak backend in utf-8 explicitly to resolve the issue.

When dealing with Chinese characters on Chinese version Windows, the file is saved in CP936 that will make the output not usable (shown and read as umlaut, etc.). Save the temp file for espeak backend in utf-8 explicitly to resolve the issue.
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          676       676           
=========================================
  Hits           676       676           
Impacted Files Coverage Δ
phonemizer/backend/espeak.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0bd28...9ae6064. Read the comment docs.

@mmmaat mmmaat merged commit 6edb0ca into bootphon:master May 12, 2020
@mmmaat
Copy link
Collaborator

mmmaat commented May 12, 2020

Thank you!

@boltomli boltomli deleted the patch-1 branch May 12, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants