Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger.py #61

Merged
merged 1 commit into from Jan 15, 2021
Merged

Update logger.py #61

merged 1 commit into from Jan 15, 2021

Conversation

gdoras
Copy link
Contributor

@gdoras gdoras commented Jan 15, 2021

import phonemizer causes a call to get_logger() which configures the default logger. This causes duplicated logs if the same logger is used in the project importing Phonemizer. To avoid it, we have to call get_logger('quiet') after importing. It might be easier to name the logger used in Phonemizer (and to set it quiet by default).

`import phonemizer` cause a call to `get_logger()` which configure the default logger. This cause duplicated logs if the same logger is used in the project importing Phonemizer. To avoid this, we have to call `get_logger('quiet')` after importing. It might be easier to name the logger used in Phonemizer, and to have it quiet by default.
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #61 (04bd80a) into master (1283d99) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          14       14           
  Lines         743      743           
=======================================
  Hits          742      742           
  Misses          1        1           
Impacted Files Coverage Δ
phonemizer/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1283d99...04bd80a. Read the comment docs.

@mmmaat mmmaat merged commit 04bd80a into bootphon:master Jan 15, 2021
@mmmaat
Copy link
Collaborator

mmmaat commented Jan 15, 2021

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants