Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern display #12

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Fix pattern display #12

merged 2 commits into from
Jan 9, 2018

Conversation

ramsey
Copy link
Contributor

@ramsey ramsey commented Mar 28, 2017

I noticed the <span> tag that surrounds json-schema--regex was missing its closing tag, so I've added the closing tag.

Additionally, this PR extends the styles for <code>, applying them to the json-schema--regex class.

@coveralls
Copy link

coveralls commented Mar 28, 2017 •
edited

Coverage Status

Coverage remained the same at 65.909% when pulling 6b74479 on ramsey:fix-pattern-display into 0225c10 on bootprint:master.

@kibertoad
Copy link

@nknapp What is missing before this is merged?

@nknapp
Copy link
Member

nknapp commented Jan 9, 2018

Sorry, I must have missed this PR.

@nknapp nknapp merged commit 4c2f990 into bootprint:master Jan 9, 2018
@nknapp
Copy link
Member

nknapp commented Jan 9, 2018

Is this also an issue in the next-branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ramsey @coveralls @kibertoad @nknapp