Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-nav-widget ms #511

Closed
1 task done
exlexv opened this issue Jun 21, 2023 · 5 comments · Fixed by #512
Closed
1 task done

top-nav-widget ms #511

exlexv opened this issue Jun 21, 2023 · 5 comments · Fixed by #512
Labels

Comments

@exlexv
Copy link
Contributor

exlexv commented Jun 21, 2023

Describe the feature that you'd like

Hello & thanks for Bootscore:)

Most buttons in header are ms-1 ms-md-2 (togglers, cart, user etc.). But top-nav-widget is registered with ms-2, so you have to edit parent theme for "ms-1 ms-md-2" or copy entire widget function or add css @media (max-width: 768px) {.top-nav-widget {margin-left: 0.25rem!important;}} . Maybe change it initially to "ms-1 ms-md-2" :)?

function bootscore_widgets_init() {
// Top Nav
...
'before_widget' => '<div class="top-nav-widget ms-2 ">',

Why is this feature needed? What problem does it solve?

No response

Checklist

  • I have searched the issues and this feature has not been requested.
@exlexv exlexv added the feature label Jun 21, 2023
@crftwrk
Copy link
Member

crftwrk commented Jun 21, 2023

Thank you for your request, but may I ask what's your case for this? top- nav widget position is next to the logo on mobile and ms-2 class is used to get space to the expanded menu. Changing to ms-1 ms-md-2 will have no effect?

@exlexv
Copy link
Contributor Author

exlexv commented Jun 21, 2023

top-nav widget as i've just re-checked is next to mobile menu toggler on mobile (and not to the logo) and the same on desktop. So when for example other buttons added to top-nav, they look ok on desktop but not on mobile. So menu-toggler, cart-toggler are devided with ms-1 on mobile, but top-nav margins ms-2

@crftwrk
Copy link
Member

crftwrk commented Jun 21, 2023

On mobile there is nothing on the left side before this widget position, only the logo https://dev.bootscore.me/.

If you think this is a usefull improvement, please fork the theme and create a pull request. We will merge it.

@exlexv
Copy link
Contributor Author

exlexv commented Jun 21, 2023

Yes, nothing on the left, only logo, and search on the right. But if you're going to add some additional buttons to the widget. Let's say we are adding 3 more buttons via wordpress admin panel to the top-nav, one after another in 3 different HTML-code containers. And the result on mobile would be like on img.
123
But with ms-1 ms-md-2 everything's gonna be ok:)

@crftwrk
Copy link
Member

crftwrk commented Jun 21, 2023

Understand. Please create a pull request, we will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants