Changing ms-2 to ms-1 ms-md-2 in top-nav-widget #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing ms-2 to ms-1 ms-md-2 in top-nav-widget. So if we would add items or buttons via wordpress admin panel to the top-nav, one after another in different HTML-code containers, we would keep 0.25rem margin between them on mobile screens instead of ms-2, which would look too wide compared to margin between other elements (navbar-toggler, cart, user). So we won't see this:)
crftwrk
approved these changes
Jun 21, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #511
Changing
ms-2toms-1 ms-md-2in top-nav-widget. So if we add items or buttons viawordpress admin panelto the top-nav widget, one after another in differentHTML-codecontainer blocks, we would keep 0.25rem margin between them on mobile screens instead of ms-2, which would look too wide compared to margin between other elements (navbar-toggler, search, cart, user — all of them use ms-1 on mobile). So we won't see this:)Closes #511