Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason of using fixed-top #692

Closed
justinkruit opened this issue Feb 23, 2024 · 1 comment · Fixed by #694 or #702
Closed

Reason of using fixed-top #692

justinkruit opened this issue Feb 23, 2024 · 1 comment · Fixed by #694 or #702

Comments

@justinkruit
Copy link
Member

What is the reason we're using fixed-top for the header?
In this case, wouldn't it actually be better to use a sticky position on the header tag itself?

That way we can also immediately replace some stuff like the following:

html,
body,
#page {
  height: 100%;
}

Which results in the #page height not going fully with the page content (this is the #pade div highlighted in devtools):
image

@crftwrk
Copy link
Member

crftwrk commented Feb 23, 2024

Have this already on the list, check here https://projekte.crftwrk.de/boilerplate-sample-content/, check the sticky-top navbar and the sticky footer https://projekte.crftwrk.de/boilerplate-sample-content/imprint/.

After the filters PR is merged, I want to open a new v6 branch and go wild.

This was referenced Feb 24, 2024
@crftwrk crftwrk linked a pull request Mar 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants