Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.0-beta1 #694

Merged
merged 198 commits into from
May 3, 2024
Merged

v6.0.0-beta1 #694

merged 198 commits into from
May 3, 2024

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Feb 24, 2024

@justinkruit Created this branch where we should add commits/PR's for the v6 release without asking for a review (except critical stuff) to speed this up. Review then in the final PR. Agree?

PR's

@crftwrk crftwrk marked this pull request as draft February 24, 2024 08:46
@justinkruit
Copy link
Member

For our situation it can be done, as we can both make changes to the PR. Normally this isn't the best way because only people with the correct permissions can edit the v6 branch and add commits to the PR.

@crftwrk
Copy link
Member Author

crftwrk commented Feb 24, 2024

Yes, this is true. But I'm not talking about months, I'm talking about days. The todo list for v6 is very long and if we merge each commit to main branch we can do release in spring 2027. If there is a PR to main branch we can simply merge it to here. The plan is to create a quick preview of v6. If it's good we can merge, if not I start from scratch again.

crftwrk and others added 24 commits February 24, 2024 10:57
…missing-files-2

Add deny direct access to the missing files
…h-text-body-secondary

Replace text-body-tertiary with text-bod-secondary
…-to-lg

Change main content breakpoints to lg
…de-main-with-div

Replace <header> and <footer> inside main with <div>
@crftwrk crftwrk changed the title v6 v6.0.0-beta1 May 2, 2024
@crftwrk crftwrk marked this pull request as ready for review May 2, 2024 17:23
@crftwrk crftwrk requested a review from justinkruit May 2, 2024 17:23
Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time for the big beta 🎉

@justinkruit justinkruit merged commit 627d429 into main May 3, 2024
@justinkruit justinkruit deleted the v6.0.0-beta1 branch May 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
5 participants