Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load style.css after main.css #201

Merged
merged 2 commits into from Aug 11, 2022
Merged

Load style.css after main.css #201

merged 2 commits into from Aug 11, 2022

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Aug 8, 2022

This is for users who are still afraid to touch a .scss file. So, they can do overrides in style.css without the !important rule.

@crftwrk crftwrk added this to In progress in 5.2.1.0 via automation Aug 8, 2022
justinkruit
justinkruit approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart plan, should have done that before.

@justinkruit
Copy link
Member

I've also added a small commit myself, to clean up the $modificated_bootscoreCss if function a bit. You can quickly check that out before the merge.

crftwrk
crftwrk commented Aug 11, 2022
View reviewed changes
Copy link
Member Author

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm happy when you just hit the merge button.

@justinkruit justinkruit merged commit 01f72c2 into main Aug 11, 2022
@justinkruit justinkruit deleted the Load-style.css-after-main.css branch August 11, 2022 08:32
@justinkruit justinkruit restored the Load-style.css-after-main.css branch August 11, 2022 08:32
@justinkruit justinkruit deleted the Load-style.css-after-main.css branch August 11, 2022 08:32
@crftwrk crftwrk mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkruit justinkruit justinkruit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.2.1.0
In progress
v5.2.1.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crftwrk @justinkruit