Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream main #256

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Upstream main #256

merged 2 commits into from
Sep 14, 2022

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Sep 14, 2022

No description provided.

@crftwrk crftwrk merged commit 23eb2ec into Refactor-offcanvas-cart Sep 14, 2022
@justinkruit
Copy link
Member

Any reason you're doing this via PRs? As far as I know updating branches based on another branch doesn't require pull requests, especially if its updating from the main branch

@crftwrk
Copy link
Member Author

crftwrk commented Sep 15, 2022

Yes, but it's just 2 clicks to update a dev branch to latest main changes via PR. So, why not staying up-to-date?

@justinkruit
Copy link
Member

Oh I totally agree to update the dev branch. I just mean, couldn't we just merge without the PR?

@crftwrk
Copy link
Member Author

crftwrk commented Sep 15, 2022

GitHub creates a PR by itself. BTW it's just a rough sketch https://dev.bootscore.me/shop/ but let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants