Remove Woo notice templates #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into it this weekend! Also, I said I was gonna look into the FA thing so I'll also promise to try some stuff out for that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #333, Woo templates should be reduced for less maintenance and more stability.
This PR does it with all alerts in templates.
alert alert-*classes with default Woowoocommerce-info,woocommerce-errorandwoocommerce-message.@extendto show them in Bootstrap's styleThis has no impact on the frontend. Tested, works fine and is already live on bootscore.me. Just click through the store and check alert classes in cart, checkout and dashboard.
@justinkruit if you agree, I'm happy when you just hit the merge button. BTW, maybe I have an idea how to solve alert icons with Fontawesome's JS version, but let's do that later.