Remove Woo btn templates #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkruit
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #333, Woo templates should be reduced for less maintenance and more stability.
This PR does it with most
btnin templates. There are still a fewbtnleft, but I want to breakdown this into smaller pieces.btn btn-*-*classes with default Woo button classes@extendto show them in Bootstrap's stylew-100, utility has been replaced by custom CSSThis has no impact on the frontend. Tested, works fine and is already live on bootscore.me. Just click through the store and check button classes in cart, checkout and dashboard.
BTW, WooCommerce has horrible selector classes, maybe SCSS looks a bit weird, but it's good.
@justinkruit if you agree, I'm happy when you just hit the merge button.