Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove woo table templates and alert clean-up #420

Merged
merged 7 commits into from
Mar 5, 2023

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Mar 4, 2023

As described in #333, Woo templates should be reduced for less maintenance and more stability.

This PR does it with most rounded class in templates.

  • Removed the last alert alert-* and replaces them by woocommerce-* classes. Due to Make icons in alerts optional and use masks instead of FA font #403, all Woo alerts have now an icon, default alerts not.
  • Removed most rounded classes in templates and replaces tem by border-radius: $border-radius;.
  • 6 files that only had changes in the rounded class has been deleted
  • Minor improvements in the _scss files

This has no impact on the frontend. Tested, works fine and is already live on bootscore.me. Just click through the store and check button classes in cart, checkout and dashboard.

@justinkruit if you agree, I'm happy when you just hit the merge button.

@crftwrk crftwrk requested a review from justinkruit March 4, 2023 14:48
@crftwrk crftwrk mentioned this pull request Mar 4, 2023
59 tasks
Copy link
Member

@justinkruit justinkruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always up for removing WooCommerce template parts as they're a pain in the butt to maintain. All looks good 👍

@justinkruit justinkruit merged commit 7e944ff into main Mar 5, 2023
@crftwrk crftwrk deleted the Remove-Woo-table-templates branch April 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants