Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross sell products #577

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Enable cross sell products #577

merged 5 commits into from
Nov 10, 2023

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Sep 18, 2023

Closes #542

Test

cross sell

@justinkruit if you like it, merge it.

@crftwrk crftwrk marked this pull request as draft September 18, 2023 17:33
@crftwrk crftwrk marked this pull request as ready for review September 19, 2023 07:07
@justinkruit
Copy link
Member

Maybe there is a different way to do this, instead of overriding the col sizes with css which I personally don't find very clean.

Maaaayyybbee we can make the cols a filter? And write a check if it's the cross sells list, and then override the cols.

@crftwrk
Copy link
Member Author

crftwrk commented Sep 19, 2023

Maaaayyybbee we can make the cols a filter? And write a check if it's the cross sells list, and then override the cols.

Of course, any idea?

@justinkruit
Copy link
Member

@crftwrk I've added 2 commits to the PR, which changes the cols into a filter and makes it 6 cols wide on the cart page.

@crftwrk
Copy link
Member Author

crftwrk commented Sep 30, 2023

Much more better, thank you!

@justinkruit justinkruit merged commit e2d1179 into main Nov 10, 2023
@justinkruit justinkruit deleted the Enable-cross-sell-products branch November 10, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cross Sell Products
2 participants