Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: #589 (added visibility tansition to .top-button to really hide it) #590

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

JWestarp
Copy link
Contributor

@JWestarp JWestarp commented Sep 30, 2023

Closes #589

@JWestarp JWestarp changed the title bug fix: #589 (added visibility tansition) bug fix: #589 (added visibility tansition to .top-button to really hide it) Sep 30, 2023
@crftwrk crftwrk self-requested a review September 30, 2023 09:59
@crftwrk
Copy link
Member

crftwrk commented Sep 30, 2023

Thank you for pointing this out!

Just 2 tiny things:

1 - We can skip visibility: visible; because Bootstrap has

.visible {
  visibility: visible !important;
}

in utilities.

2 - Using .3s is cleaner than 300ms and used in the entire theme.

Overall code:

.top-button {
  right: 5%;
  bottom: 30px;
  opacity: 0;
  visibility: hidden;
  transition: visibility 0s linear .3s, opacity .3s;

  &.visible {
    opacity: 1;
    transition: visibility 0s linear 0s, opacity .3s;
  }
}

If you want to change this quickly, we are ready to merge.

@JWestarp
Copy link
Contributor Author

JWestarp commented Oct 1, 2023

@crftwrk Thanks for the quick reply. Yes, i agree with you.
I just changed that.

Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crftwrk crftwrk merged commit 7d7fbac into bootscore:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] .top-button is clickable when not visible
2 participants