Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An adjustment that enables removing shop thumbnails in a supported way. #609

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

xoneill007
Copy link
Contributor

Per https://github.com/orgs/bootscore/discussions/597

This adjustment is in-line with effort to reduce WC templates #333

[IMPROVEMENT] Removed func custom_loop_product_thumbnail() from bootscore/woocommerce/inc/wc-loop.php

[IMPROVEMENT] Modified bootscore/woocommerce/inc/wc-loop.php to fetch both, category and product loop images

The above changes allow the following to work as expected:

// Remove product thumbnails from the shop loop:
remove_action( 'woocommerce_before_shop_loop_item_title', 'woocommerce_template_loop_product_thumbnail', 10 );

On branch reduce-WC-templates
Your branch is up to date with 'origin/reduce-WC-templates'.

Changes to be committed:
modified: scss/bootscore_woocommerce/_wc_loop.scss
modified: woocommerce/inc/wc-loop.php

This adjustment that is in-line with effort to reduce WC templates bootscore#333

[IMPROVEMENT] Removed func custom_loop_product_thumbnail() from bootscore/woocommerce/inc/wc-loop.php

[IMPROVEMENT] Modified bootscore/woocommerce/inc/wc-loop.php to fetch both, category and product loop images

The above changes allow the following to work as expected:

// Remove product thumbnails from the shop loop:
remove_action( 'woocommerce_before_shop_loop_item_title', 'woocommerce_template_loop_product_thumbnail', 10 );

On branch reduce-WC-templates
Your branch is up to date with 'origin/reduce-WC-templates'.

Changes to be committed:
	modified:   scss/bootscore_woocommerce/_wc_loop.scss
	modified:   woocommerce/inc/wc-loop.php
@crftwrk crftwrk self-requested a review October 23, 2023 09:56
Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crftwrk crftwrk merged commit 9a20679 into bootscore:main Oct 23, 2023
@xoneill007 xoneill007 deleted the reduce-WC-templates branch October 23, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants