Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove favicons and links in header.php #634

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Nov 22, 2023

Closes #419
PR in child bootscore/bootscore-child#34

This PR removes the favicons and links to them in header.php

Why?

  • It's against the WordPress codex. These links were one (now the last) reason why we couldn't publish to the WP theme repository.
  • Buggy with Android Chrome and Windows 8/10.
  • Users do not take this step serious enough. Most developers works on Windows with Chrome, and didn’t check on any other device. I'm an Apple user and I see beautiful designed sites but viewing them in Safari shows still the blue b :-/

Think we should give this back to the Customizer and mention in the docs that the 90kb plugin https://wordpress.org/plugins/favicon-by-realfavicongenerator/ leads to the best results.

When merged, we can theoretically ask for a theme review in the WP repository, question is if we want to go this way.

@justinkruit if you agree, please merge.

@crftwrk crftwrk added the documentation Improvements or additions to documentation label Nov 22, 2023
@justinkruit
Copy link
Member

I'm an Apple user and I see beautiful designed sites but viewing them in Safari shows still the blue b :-/

That's actually quite funny 😂

When merged, we can theoretically ask for a theme review in the WP repository, question is if we want to go this way.

Personally, not the biggest fan. I think this theme relies on a developer making changes to make it fit their needs. For me the WP repository is more suited for non-developers.

@justinkruit justinkruit merged commit 4d3e78e into main Nov 24, 2023
@justinkruit justinkruit deleted the Remove-linked-favicons-in-header.php branch November 24, 2023 12:21
@crftwrk
Copy link
Member Author

crftwrk commented Nov 24, 2023

For me the WP repository is more suited for non-developers.

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Some Irritations concerning the favicon docu:
2 participants