Rewrite main.scss #645
Merged
Rewrite main.scss #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
That's cool, thank you! Just two things:
|
crftwrk
added
child
documentation
Good catch! Will fix this soon.
When this is done, I'll also make a PR in the child theme 馃憤 |
crftwrk
approved these changes
Dec 10, 2023
justinkruit
added a commit
to bootscore/bootscore-child
that referenced
this pull request
Dec 10, 2023
Will bring the changes of bootscore/bootscore#645 to the child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #640 we highlighted that a rewrite of the
main.scssis needed to give the users more control over Bootstrap. With this PR that will be achieved.The variables are set before Bootstrap so everything is better overridable.
A new
_bscore_maps.scsshas been added so maps can also be overridden.And lastly a new
_bscore_utilities.scsshas been added and loaded after the Bootstrap utilities so they can be added upon (docs).I've tested the compiling locally, and nothing seems to be missing.
@crftwrk If you like it, merge it. 馃槣