Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix wc 8.5 alerts" #678

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

crftwrk
Copy link
Member

@crftwrk crftwrk commented Feb 7, 2024

Reverts #671

WC 8.6 fixes the issue with the broken alerts https://developer.woo.com/2024/02/06/woocommerce-8-6-rc-classic-notice-templates-for-classic-themes-more/. In this case we should revert #671 and using our previous alerts again, because they are proved and no WC template overrides for them are used in theme.

Test

  • WooCommerce 8.6-RC.1 is installed.
  • https://dev.bootscore.me/product/beanie/. Add product twice to the cart to see success and danger message, check alert classes. Classes woocommerce-message, woocommerce-error and woocommerce-info for the empty cart are used again.
  • Go to the cart and remove product, check alert classes.

@hsankala FYI
@justinkruit IYLIMI

@crftwrk crftwrk marked this pull request as draft February 7, 2024 10:10
@crftwrk crftwrk marked this pull request as ready for review February 7, 2024 10:11
@crftwrk crftwrk marked this pull request as draft February 7, 2024 10:11
@crftwrk crftwrk marked this pull request as ready for review February 7, 2024 10:35
@justinkruit
Copy link
Member

Will test this PR in the weekend. I want to make sure it doesn't break when the theme has Gutenberg usage

@crftwrk
Copy link
Member Author

crftwrk commented Feb 16, 2024

I can confirm that the alerts have been fixed in WC 8.6. Check https://bootscore.me/shop/ alerts in offcanvas cart, cart and checkout.

@justinkruit
Copy link
Member

I can confirm that the alerts have been fixed in WC 8.6. Check https://bootscore.me/shop/ alerts in offcanvas cart, cart and checkout.

Also made sure it's working when users have enabled Gutenberg in their theme.

@justinkruit justinkruit merged commit d59cf7b into main Feb 16, 2024
@justinkruit justinkruit deleted the revert-671-Fix-WC-8.5-alerts branch February 16, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants