Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the rhs column has a set width #7

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Ensure that the rhs column has a set width #7

merged 1 commit into from
Jul 29, 2021

Conversation

timgws
Copy link
Contributor

@timgws timgws commented Jul 20, 2021

The default for col is to have max-width set to 100%, sadly, this means that if there is content (such as a large image) that takes more then calc(100%-25%) of viewport, then the menu on the RHS will not show.

This tiny PR sets a width for the column, which ensures that the menu will appear on the RHS. Ideally, there would be a check here to ensure that the col-md-7 is only applied when the sidebar has content.

@crftwrk
Copy link
Member

crftwrk commented Jul 29, 2021

Thanks for this PR. col class is used for dynamic width of content if sidebar has no content. This is fine if you use just excerpt in post list. But you're right, if you using content view in post list, then sidebar moves to bottom when there are large images.

Making still the column dynamic with col-md-* classes could be done with JavaScript. But I would like to reduce that rather than expand it. So, if there is no sidebar, user can remove col-md-7 col-xxl-9 classes. This can easily be done in a upgrade-safe way by copy index.php to child-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants