Update checker 5.3

update/Puc/v5/PucFactory.php

@@ -4,7 +4,7 @@
 
 if ( !class_exists(PucFactory::class, false) ):
 
-	class PucFactory extends \YahnisElsts\PluginUpdateChecker\v5p2\PucFactory {
+	class PucFactory extends \YahnisElsts\PluginUpdateChecker\v5p3\PucFactory {
 	}
 
 endif;

update/Puc/v5p2/Autoloader.php → update/Puc/v5p3/Autoloader.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(Autoloader::class, false) ):
 

update/Puc/v5p2/DebugBar/Extension.php → update/Puc/v5p3/DebugBar/Extension.php

@@ -1,8 +1,8 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\PucFactory;
-use YahnisElsts\PluginUpdateChecker\v5p2\UpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\PucFactory;
+use YahnisElsts\PluginUpdateChecker\v5p3\UpdateChecker;
 
 if ( !class_exists(Extension::class, false) ):
 

update/Puc/v5p2/DebugBar/Panel.php → update/Puc/v5p3/DebugBar/Panel.php

@@ -1,7 +1,7 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\UpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\UpdateChecker;
 
 if ( !class_exists(Panel::class, false) && class_exists('Debug_Bar_Panel', false) ):
 

update/Puc/v5p2/DebugBar/PluginExtension.php → update/Puc/v5p3/DebugBar/PluginExtension.php

@@ -1,8 +1,8 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Plugin\UpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\Plugin\UpdateChecker;
 
 if ( !class_exists(PluginExtension::class, false) ):
 

update/Puc/v5p2/DebugBar/PluginPanel.php → update/Puc/v5p3/DebugBar/PluginPanel.php

@@ -1,7 +1,7 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Plugin\UpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\Plugin\UpdateChecker;
 
 if ( !class_exists(PluginPanel::class, false) ):
 

update/Puc/v5p2/DebugBar/ThemePanel.php → update/Puc/v5p3/DebugBar/ThemePanel.php

@@ -1,8 +1,8 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Theme\UpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\Theme\UpdateChecker;
 
 if ( !class_exists(ThemePanel::class, false) ):
 

update/Puc/v5p2/InstalledPackage.php → update/Puc/v5p3/InstalledPackage.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(InstalledPackage::class, false) ):
 

update/Puc/v5p2/Metadata.php → update/Puc/v5p3/Metadata.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 use LogicException;
 use stdClass;

update/Puc/v5p2/OAuthSignature.php → update/Puc/v5p3/OAuthSignature.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(OAuthSignature::class, false) ):
 

update/Puc/v5p2/Plugin/Package.php → update/Puc/v5p3/Plugin/Package.php

@@ -1,8 +1,8 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\InstalledPackage;
-use YahnisElsts\PluginUpdateChecker\v5p2\PucFactory;
+use YahnisElsts\PluginUpdateChecker\v5p3\InstalledPackage;
+use YahnisElsts\PluginUpdateChecker\v5p3\PucFactory;
 
 if ( !class_exists(Package::class, false) ):
 

update/Puc/v5p2/Plugin/PluginInfo.php → update/Puc/v5p3/Plugin/PluginInfo.php

@@ -1,7 +1,7 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Metadata;
+use YahnisElsts\PluginUpdateChecker\v5p3\Metadata;
 
 if ( !class_exists(PluginInfo::class, false) ):
 

update/Puc/v5p2/Plugin/Ui.php → update/Puc/v5p3/Plugin/Ui.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
 if ( !class_exists('Ui', false) ):
 	/**

update/Puc/v5p2/Plugin/Update.php → update/Puc/v5p3/Plugin/Update.php

@@ -1,7 +1,7 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Update as BaseUpdate;
+use YahnisElsts\PluginUpdateChecker\v5p3\Update as BaseUpdate;
 
 if ( !class_exists(Update::class, false) ):
 

update/Puc/v5p2/Plugin/UpdateChecker.php → update/Puc/v5p3/Plugin/UpdateChecker.php

@@ -1,10 +1,10 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\InstalledPackage;
-use YahnisElsts\PluginUpdateChecker\v5p2\UpdateChecker as BaseUpdateChecker;
-use YahnisElsts\PluginUpdateChecker\v5p2\Scheduler;
-use YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+use YahnisElsts\PluginUpdateChecker\v5p3\InstalledPackage;
+use YahnisElsts\PluginUpdateChecker\v5p3\UpdateChecker as BaseUpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\Scheduler;
+use YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
 if ( !class_exists(UpdateChecker::class, false) ):
 

update/Puc/v5p2/PucFactory.php → update/Puc/v5p3/PucFactory.php

@@ -1,10 +1,10 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
-use YahnisElsts\PluginUpdateChecker\v5p2\Theme;
-use YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+use YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
+use YahnisElsts\PluginUpdateChecker\v5p3\Theme;
+use YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !class_exists(PucFactory::class, false) ):
 
@@ -147,7 +147,7 @@ public static function buildUpdateChecker($metadataUrl, $fullPath, $slug = '', $
 		 *
 		 * Normalize a filesystem path. Introduced in WP 3.9.
 		 * Copying here allows use of the class on earlier versions.
-		 * This version adapted from WP 4.8.2 (unchanged since 4.5.2)
+		 * This version adapted from WP 4.8.2 (unchanged since 4.5.3)
 		 *
 		 * @param string $path Path to normalize.
 		 * @return string Normalized path.

update/Puc/v5p2/Scheduler.php → update/Puc/v5p3/Scheduler.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(Scheduler::class, false) ):
 
@@ -210,7 +210,7 @@ protected function getEffectiveCheckPeriod() {
 				//Check less frequently if it's already known that an update is available.
 				$period = $this->throttledCheckPeriod * 3600;
 			} else if ( defined('DOING_CRON') && constant('DOING_CRON') ) {
-				//WordPress cron schedules are not exact, so lets do an update check even
+				//WordPress cron schedules are not exact, so let's do an update check even
 				//if slightly less than $checkPeriod hours have elapsed since the last check.
 				$cronFuzziness = 20 * 60;
 				$period = $this->checkPeriod * 3600 - $cronFuzziness;

update/Puc/v5p2/StateStore.php → update/Puc/v5p3/StateStore.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(StateStore::class, false) ):
 

update/Puc/v5p2/Theme/Package.php → update/Puc/v5p3/Theme/Package.php

@@ -1,7 +1,7 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Theme;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Theme;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\InstalledPackage;
+use YahnisElsts\PluginUpdateChecker\v5p3\InstalledPackage;
 
 if ( !class_exists(Package::class, false) ):
 

update/Puc/v5p2/Theme/Update.php → update/Puc/v5p3/Theme/Update.php

@@ -1,8 +1,8 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Theme;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Theme;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Update as BaseUpdate;
+use YahnisElsts\PluginUpdateChecker\v5p3\Update as BaseUpdate;
 
 if ( !class_exists(Update::class, false) ):
 

update/Puc/v5p2/Theme/UpdateChecker.php → update/Puc/v5p3/Theme/UpdateChecker.php

@@ -1,11 +1,11 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Theme;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Theme;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\UpdateChecker as BaseUpdateChecker;
-use YahnisElsts\PluginUpdateChecker\v5p2\InstalledPackage;
-use YahnisElsts\PluginUpdateChecker\v5p2\Scheduler;
-use YahnisElsts\PluginUpdateChecker\v5p2\DebugBar;
+use YahnisElsts\PluginUpdateChecker\v5p3\UpdateChecker as BaseUpdateChecker;
+use YahnisElsts\PluginUpdateChecker\v5p3\InstalledPackage;
+use YahnisElsts\PluginUpdateChecker\v5p3\Scheduler;
+use YahnisElsts\PluginUpdateChecker\v5p3\DebugBar;
 
 if ( !class_exists(UpdateChecker::class, false) ):
 

update/Puc/v5p2/Update.php → update/Puc/v5p3/Update.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 use stdClass;
 

update/Puc/v5p2/UpdateChecker.php → update/Puc/v5p3/UpdateChecker.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 use stdClass;
 use WP_Error;
@@ -980,7 +980,11 @@ protected function isBadDirectoryStructure($remoteSource) {
 		 * Initialize the update checker Debug Bar plugin/add-on thingy.
 		 */
 		public function maybeInitDebugBar() {
-			if ( class_exists('Debug_Bar', false) && file_exists(dirname(__FILE__) . '/DebugBar') ) {
+			if (
+				class_exists('Debug_Bar', false)
+				&& class_exists('Debug_Bar_Panel', false)
+				&& file_exists(dirname(__FILE__) . '/DebugBar')
+			) {
 				$this->debugBarExtension = $this->createDebugBarExtension();
 			}
 		}

update/Puc/v5p2/UpgraderStatus.php → update/Puc/v5p3/UpgraderStatus.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(UpgraderStatus::class, false) ):
 

update/Puc/v5p2/Utils.php → update/Puc/v5p3/Utils.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2;
+namespace YahnisElsts\PluginUpdateChecker\v5p3;
 
 if ( !class_exists(Utils::class, false) ):
 

update/Puc/v5p2/Vcs/Api.php → update/Puc/v5p3/Vcs/Api.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 use Parsedown;
 use PucReadmeParser;

update/Puc/v5p2/Vcs/BaseChecker.php → update/Puc/v5p3/Vcs/BaseChecker.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !interface_exists(BaseChecker::class, false) ):
 

update/Puc/v5p2/Vcs/BitBucketApi.php → update/Puc/v5p3/Vcs/BitBucketApi.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\OAuthSignature;
-use YahnisElsts\PluginUpdateChecker\v5p2\Utils;
+use YahnisElsts\PluginUpdateChecker\v5p3\OAuthSignature;
+use YahnisElsts\PluginUpdateChecker\v5p3\Utils;
 
 if ( !class_exists(BitBucketApi::class, false) ):
 

update/Puc/v5p2/Vcs/GitHubApi.php → update/Puc/v5p3/Vcs/GitHubApi.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 use Parsedown;
 

update/Puc/v5p2/Vcs/GitLabApi.php → update/Puc/v5p3/Vcs/GitLabApi.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !class_exists(GitLabApi::class, false) ):
 

update/Puc/v5p2/Vcs/PluginUpdateChecker.php → update/Puc/v5p3/Vcs/PluginUpdateChecker.php

@@ -1,8 +1,8 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Plugin;
+use YahnisElsts\PluginUpdateChecker\v5p3\Plugin;
 
 if ( !class_exists(PluginUpdateChecker::class, false) ):
 
@@ -85,6 +85,21 @@ public function requestInfo($unusedParameter = null) {
 				$this->setInfoFromHeader($remoteHeader, $info);
 			}
 
+			//Sanity check: Reject updates that don't have a version number.
+			//This can happen when we're using a branch, and we either fail to retrieve the main plugin
+			//file or the file doesn't have a "Version" header.
+			if ( empty($info->version) ) {
+				do_action(
+					'puc_api_error',
+					new \WP_Error(
+						'puc-no-plugin-version',
+						'Could not find the version number in the repository.'
+					),
+					null, null, $this->slug
+				);
+				return null;
+			}
+
 			//Try parsing readme.txt. If it's formatted according to WordPress.org standards, it will contain
 			//a lot of useful information like the required/tested WP version, changelog, and so on.
 			if ( $this->readmeTxtExistsLocally() ) {

update/Puc/v5p2/Vcs/Reference.php → update/Puc/v5p3/Vcs/Reference.php

@@ -1,5 +1,5 @@
 <?php
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !class_exists(Reference::class, false) ):
 

update/Puc/v5p2/Vcs/ReleaseAssetSupport.php → update/Puc/v5p3/Vcs/ReleaseAssetSupport.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !trait_exists(ReleaseAssetSupport::class, false) ) :
 

update/Puc/v5p2/Vcs/ReleaseFilteringFeature.php → update/Puc/v5p3/Vcs/ReleaseFilteringFeature.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !trait_exists(ReleaseFilteringFeature::class, false) ) :
 

update/Puc/v5p2/Vcs/ThemeUpdateChecker.php → update/Puc/v5p3/Vcs/ThemeUpdateChecker.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
-use YahnisElsts\PluginUpdateChecker\v5p2\Theme;
-use YahnisElsts\PluginUpdateChecker\v5p2\Utils;
+use YahnisElsts\PluginUpdateChecker\v5p3\Theme;
+use YahnisElsts\PluginUpdateChecker\v5p3\Utils;
 
 if ( !class_exists(ThemeUpdateChecker::class, false) ):
 

update/Puc/v5p2/Vcs/VcsCheckerMethods.php → update/Puc/v5p3/Vcs/VcsCheckerMethods.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace YahnisElsts\PluginUpdateChecker\v5p2\Vcs;
+namespace YahnisElsts\PluginUpdateChecker\v5p3\Vcs;
 
 if ( !trait_exists(VcsCheckerMethods::class, false) ) :