Skip to content

Commit

Permalink
Change concat to << since the buffer no longer supports the former (
Browse files Browse the repository at this point in the history
#652)

Co-authored-by: Uwe Kubosch <uwe@datek.no>
  • Loading branch information
donv and UweKubosch committed Jul 24, 2022
1 parent 0a75c79 commit eb6bcdd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Dangerfile
Expand Up @@ -19,8 +19,8 @@ has_changelog_changes = git.modified_files.include?("CHANGELOG.md")
# You've made changes to lib, but didn't write any tests?
# ------------------------------------------------------------------------------
if has_lib_changes && !has_test_changes
warn("There are code changes, but no corresponding tests. "\
"Please include tests if this PR introduces any modifications in "\
warn("There are code changes, but no corresponding tests. " \
"Please include tests if this PR introduces any modifications in " \
"#{project_name}'s behavior.",
sticky: false)
end
Expand All @@ -36,8 +36,8 @@ if !has_changelog_changes && has_lib_changes
* [##{pr_number}](#{pr_url}): #{github.pr_title} - [@#{github.pr_author}](https://github.com/#{github.pr_author}).
```
MARKDOWN
warn("Please update CHANGELOG.md with a description of your changes. "\
"If this PR is not a user-facing change (e.g. just refactoring), "\
warn("Please update CHANGELOG.md with a description of your changes. " \
"If this PR is not a user-facing change (e.g. just refactoring), " \
"you can disregard this.", sticky: false)
end

Expand Down
4 changes: 2 additions & 2 deletions bootstrap_form.gemspec
Expand Up @@ -9,9 +9,9 @@ Gem::Specification.new do |s|
s.authors = ["Stephen Potenza", "Carlos Lopes"]
s.email = ["potenza@gmail.com", "carlos.el.lopes@gmail.com"]
s.homepage = "https://github.com/bootstrap-ruby/bootstrap_form"
s.summary = "Rails form builder that makes it easy to style forms using "\
s.summary = "Rails form builder that makes it easy to style forms using " \
"Bootstrap 5"
s.description = "bootstrap_form is a rails form builder that makes it super "\
s.description = "bootstrap_form is a rails form builder that makes it super " \
"easy to create beautiful-looking forms using Bootstrap 5"
s.license = "MIT"
s.metadata = { "rubygems_mfa_required" => "true" }
Expand Down
2 changes: 1 addition & 1 deletion lib/bootstrap_form/form_group.rb
Expand Up @@ -34,7 +34,7 @@ def form_group_content_tag(name, field_name, without_field_name, options, html_o

def form_group_content(label, help_text, options, &block)
if group_layout_horizontal?(options[:layout])
concat(label).concat(tag.div(capture(&block) + help_text, class: form_group_control_class(options)))
concat(label) << tag.div(capture(&block) + help_text, class: form_group_control_class(options))
else
# Floating labels need to be rendered after the field
concat(label) unless options[:floating]
Expand Down

0 comments on commit eb6bcdd

Please sign in to comment.