Moves help text in horiz. forms under the control #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#454](https://github.com/bootstrap-ruby/bootstrap_form/pull/454): Moves help text in horiz. forms under the control - [@tekkla](https://github.com/tekkla).Generated by 🚫 Danger |
lcreid
approved these changes
Mar 20, 2018
There was a problem hiding this comment.
Good catch, and nice first contribution! Thanks very much for this PR. It looks good to me. I hope we will be merging this in the next few days. @mattbrictson could you please take a quick look at this?
|
Looks great, thanks! 🙌 I'll rebase and merge this once #455 is in. |
added 2 commits
March 21, 2018 08:55
Updates test to reflect the changes made in form_group method
When using horizontal forms the help text is placed inside the created row but as sibling of the cols for label and control. This codechange moves the help text inside the col of the control so it gets aligned with/under the control.
|
Travis complains about this.
Do I have to change something or is it a problem on your side? |
|
This has been merged and the master build is passing, so there is nothing more we need to do. We're all good. Thanks for checking! |
xire28
pushed a commit
to xire28/bootstrap_form
that referenced
this pull request
Mar 30, 2018
* Updates help messages for horizontal forms test Updates test to reflect the changes made in form_group method * Moves help text in horiz. forms under the control When using horizontal forms the help text is placed inside the created row but as sibling of the cols for label and control. This codechange moves the help text inside the col of the control so it gets aligned with/under the control.
Closed
lcreid
pushed a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
* Updates help messages for horizontal forms test Updates test to reflect the changes made in form_group method * Moves help text in horiz. forms under the control When using horizontal forms the help text is placed inside the created row but as sibling of the cols for label and control. This codechange moves the help text inside the col of the control so it gets aligned with/under the control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using horizontal forms the help text is placed inside the created row but as sibling of the cols for label and control. This codechange moves the help text inside the col of the control so it gets aligned with/under the control.
Before:
After:
