Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 6.1 tests on master #586

Merged
merged 6 commits into from
Apr 12, 2021
Merged

Fix Rails 6.1 tests on master #586

merged 6 commits into from
Apr 12, 2021

Commits on Apr 11, 2021

  1. Fix tests for Rails 6.1

    thimo committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    1430ad0 View commit details
    Browse the repository at this point in the history
  2. Fix Rubocop offenses

    bootstrap_form.gemspec:27:29: C: Gemspec/RequiredRubyVersion: required_ruby_version (2.5, declared in bootstrap_form.gemspec) and TargetRubyVersion (2.7, which may be specified in .rubocop.yml) should be equal.
      s.required_ruby_version = ">= 2.5"
                                ^^^^^^^^
    lib/bootstrap_form/form_group.rb:14:30: C: [Correctable] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. (https://rubystyle.guide#no-double-indent)
                                 :input_group_class, :label_col, :control_col,
                                 ^^^^^^^^^^^^^^^^^^
    lib/bootstrap_form/form_group.rb:15:30: C: [Correctable] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. (https://rubystyle.guide#no-double-indent)
                                 :add_control_col_class, :layout, :prepend)) do
                                 ^^^^^^^^^^^^^^^^^^^^^^
    test/bootstrap_form_test.rb:123:103: C: [Correctable] Style/IfUnlessModifier: Modifier form of if makes the line too long. (https://rubystyle.guide#if-as-a-modifier)
            <form accept-charset="UTF-8" action="/users" method="post" role="form" #{'data-remote="true"' if ::Rails::VERSION::STRING < "6.1"}>
                                                                                                          ^^
    test/bootstrap_form_test.rb:123:133: C: [Correctable] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
            <form accept-charset="UTF-8" action="/users" method="post" role="form" #{'data-remote="true"' if ::Rails::VERSION::STRING < "6.1"}>
                                                                                                                                        ^^^^^
    test/bootstrap_rich_text_area_test.rb:23:54: C: [Correctable] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
          "http://test.host/rails/active_storage/blobs/#{"redirect/" if ::Rails::VERSION::STRING >= "6.1"}:signed_id/:filename"
                                                         ^^^^^^^^^^^
    test/bootstrap_rich_text_area_test.rb:23:97: C: [Correctable] Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
          "http://test.host/rails/active_storage/blobs/#{"redirect/" if ::Rails::VERSION::STRING >= "6.1"}:signed_id/:filename"
                                                                                                    ^^^^^
    thimo committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    cf2960b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07d1da2 View commit details
    Browse the repository at this point in the history
  4. Update CHANGELOG

    thimo committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    7cdee6e View commit details
    Browse the repository at this point in the history
  5. Rails Edge requires Ruby 2.7+

    thimo committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    91c8c97 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    9558eff View commit details
    Browse the repository at this point in the history